Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DATAVIZ: Merge upstream 4.0.3 #4

Merged
merged 215 commits into from
Nov 15, 2023
Merged

DATAVIZ: Merge upstream 4.0.3 #4

merged 215 commits into from
Nov 15, 2023

Conversation

Kaapp
Copy link

@Kaapp Kaapp commented Nov 15, 2023

This should have kept our changes, commits to modules/tiles/* are still in history. This also includes a fix to one of the issues I found with 3d-tiles implicit parsing, but doesn't look like it would fix the other so I will raise another PR after with that

git remote add upstream git@github.com:visgl/loaders.gl.git
git fetch upstream
git merge --no-ff v4.0.3
# fixed merge conflicts, basically just package.json
yarn install
yarn build
git commit # although did this via Github Desktop
git push -u origin merge-4.0.3-master

belom88 and others added 30 commits July 13, 2023 17:14
@belom88
v4.0.0-alpha.13
32421ea
@belom88
fix(tile-converter): i3s->3dtiles regression (visgl#2550)
452e5cf
@belom88
fix(3d-tiles): implicit tiling v1.1 (visgl#2549)
0b43313
@belom88
v4.0.0-alpha.14
dd88559
@belom88
chore(tile-converter): update i3s-server manual (visgl#2552)
ed13bdb
@belom88
chore: update CHANGELOG.md (visgl#2551)
3f3a88a
@belom88
fix(tile-converter): CesiumION tileset URL (visgl#2560)
4400d4b
@dependabot
chore(deps): bump word-wrap in /test/apps/typescript-test (visgl#2559)
132c452
@nreese
fix(docs): JSONLoader _rootObjectBatches removed but not mentioned in…
729619b 
… upgrade guide (visgl#2558)
@dependabot
chore(deps): bump semver from 5.7.1 to 5.7.2 in /website (visgl#2546)
edffd47
@belom88
feat(tile-converter): i3s-server bundle (visgl#2555)
48e473d
@dariaterekhova-actionengine
chore(tile-converter): Support for SLPKs larger than 2 Gb (visgl#2547)
71e48c3
@belom88
chore(tile-converter): bump i3s-server deps (visgl#2561)
93e3678
@belom88
v4.0.0-alpha.15
47467ab
@belom88
chore(tile-converter): i3s-server convert to ts (visgl#2562)
c4e099c
@dependabot
chore(deps): bump semver from 5.7.1 to 5.7.2 (visgl#2545)
1f99018
@dependabot
chore(deps): bump semver in /test/apps/typescript-test (visgl#2544)
d02c8ff
@belom88
chore(tile-converter): i3s-server tests (visgl#2563)
1dabc14
@belom88
docs(tile-converter): I3S Server (visgl#2564)
0db5012
@dariaterekhova-actionengine
chore(tile-converter): create SLPK hash during serve (visgl#2565)
5df9cb0
@belom88
v4.0.0-alpha.16
87e9714
@chrisgervang
fix(obj): Improved vertex colors parsing (visgl#2569)
a19c1c5 
* fix(obj) parse vertex colors

* v3.4.9 changelog
@felixpalmer
Add triangulate property to geojsonToBinary (visgl#2571)
8247945
@ibgreen
docs(chore): core API documentation improvements (visgl#2573)
6869583
@belom88
v4.0.0-alpha.17
68a743e
@belom88
chore(tile-converter): 3dtiles - exclude Tile3D and Tileset3D (visgl#…
f51905b 
…2574)
@ibgreen
chore(core): Refactor fetchFile to handle Node.js local file loading (v…
6e4979c 
…isgl#2575)
@dariaterekhova-actionengine
docs(tile-converter): Add documentation for SLPK Extractor (visgl#2567)
86a1ff4
@ibgreen
fix: Bump and remove @xmldom/xmldom (input validation issue) (visgl#2582
0a0b7d3 
)
@belom88
fix(tile-converter): skip failing content (visgl#2576)
d92fa35
belom88 and others added 17 commits November 3, 2023 12:00
@belom88
test: run workers from source code (visgl#2762)
fdd6061
@dariaterekhova-actionengine
v4.0.2
471058d
@ibgreen
chore(loader-utils): split Worker/WorkerWithEncoder types (visgl#2768)
e5f9759
@ibgreen
chore(excel): Fix batched loader adapter from atomic parse (visgl#2769)
b21dec6
@ibgreen
chore: parseFile accepts ReadableFile (visgl#2770)
e42f9fd
@ibgreen
chore: Dependencies (visgl#2772)
d90ffc4
@ibgreen
fix(3d-tiles): Enable Tiles3DLoader tests (visgl#2771)
59fc842
@ibgreen
feat(parquet): Enable Parquet WASM loader (visgl#2773)
de10c5d
@ibgreen
chore: Update all dependencies to ^4.0.0 (visgl#2775)
be7000f
@belom88
fix(examples): run 'geospatial' locally (visgl#2776)
4184949
@ibgreen
docs(arrowjs): Update Arrow docs and release notes (visgl#2778)
21ed934
@ibgreen
fix: Use "latest" version tag when loading from unpkg (visgl#2779)
708a26d
@lixun910
fix(Arrow): featureIds not correctly parsed from MultiPolygon w/ hole…
d29fd1e 
…s in arrow util (WIP) (visgl#2777)

Signed-off-by: Xun Li <lixun910@gmail.com>
@ibgreen
fix: Revert parquet-wasm integration (visgl#2781)
d3e1f0b
@mspivak-actionengine
feat(tile-converter): estimation of time remaining (visgl#2774)
8c4f971
@dariaterekhova-actionengine
v4.0.3
03c8718
@Kaapp
Merge tag 'v4.0.3' into merge-4.0.3-master
1cfd924 
v4.0.3
@Kaapp Kaapp self-assigned this Nov 15, 2023
Rennzie
Rennzie reviewed Nov 15, 2023
View reviewed changes
Copy link
Member

@Rennzie Rennzie left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you do your fix in a different PR given it's unrelated to to upstream syncing?

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6878254529

  • 11355 of 18095 (62.75%) changed or added relevant lines in 520 files are covered.
  • 9682 unchanged lines in 385 files lost coverage.
  • Overall coverage increased (+9.2%) to 67.389%
Changes Missing Coverage Covered Lines Changed/Added Lines %
modules/3d-tiles/src/lib/parsers/parse-3d-tile-gltf.ts 11 12 91.67%
modules/arrow/src/geoarrow/convert-geoarrow-to-binary-geometry.ts 261 262 99.62%
modules/arrow/src/tables/convert-table-to-arrow.ts 0 1 0.0%
modules/bson/src/bson-loader.ts 5 6 83.33%
modules/core/src/lib/api/encode-table.ts 12 13 92.31%
modules/core/src/lib/api/parse.ts 41 42 97.62%
modules/core/src/lib/fetch/read-array-buffer.ts 2 3 66.67%
modules/core/src/lib/loader-utils/get-data.ts 3 4 75.0%
modules/core/src/lib/utils/response-utils.ts 11 12 91.67%
modules/crypto/src/lib/algorithms/md5-wasm.ts 6 7 85.71%
Files with Coverage Reduction New Missed Lines %
modules/3d-tiles/src/lib/parsers/helpers/parse-utils.ts 1 84.38%
modules/3d-tiles/src/lib/parsers/parse-3d-tile-gltf.ts 1 93.02%
modules/3d-tiles/src/lib/parsers/parse-3d-tile.ts 1 95.08%
modules/arrow/src/arrow-writer.ts 1 94.59%
modules/arrow/src/lib/parse-arrow-sync.ts 1 88.37%
modules/bson/src/bson-writer.ts 1 87.5%
modules/core/src/iterators/make-iterator/make-iterator.ts 1 95.0%
modules/core/src/lib/api/parse-in-batches.ts 1 93.28%
modules/core/src/lib/api/register-loaders.ts 1 94.0%
modules/core/src/lib/loader-utils/get-fetch-function.ts 1 93.88%
Totals Coverage Status
Change from base Build 6616027796: 9.2%
Covered Lines: 68494
Relevant Lines: 102863
💛 - Coveralls

@Kaapp
Copy link
Author

Kaapp commented Nov 15, 2023

Sorry poor wording @Rennzie, this doesn't include my fix or any changes from me - there's an upstream fix for one issue I found

@Rennzie
Copy link
Member

Rennzie commented Nov 15, 2023

Sorry poor wording @Rennzie, this doesn't include my fix or any changes from me - there's an upstream fix for one issue I found

Ah ok. Fair dues.

@Rennzie Rennzie self-requested a review November 15, 2023 14:21
@Kaapp Kaapp merged commit 67d30fd into master Nov 15, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rennzie Rennzie Rennzie approved these changes

@Gmadges Gmadges Gmadges approved these changes

@justinmanley justinmanley Awaiting requested review from justinmanley

@theoistrate theoistrate Awaiting requested review from theoistrate

Assignees

@Kaapp Kaapp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.